-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DF-832-Prototype/search filters accordion #1434
Closed
JohnHeeryTNA
wants to merge
49
commits into
develop
from
prototype/search-mobile-accordian-form-integrate
Closed
DF-832-Prototype/search filters accordion #1434
JohnHeeryTNA
wants to merge
49
commits into
develop
from
prototype/search-mobile-accordian-form-integrate
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm-integrate' of https://github.com/nationalarchives/ds-wagtail into prototype/search-mobile-accordian-form-integrate
…tps://github.com/nationalarchives/ds-wagtail into prototype/search-mobile-accordian-form-integrate tidy formating
…tegrate # Conflicts: # sass/includes/search/_search-filters.scss # templates/search/blocks/search_filters.html
Closing this as the work will be re-done in the new ds-search repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket URL: https://national-archives.atlassian.net/browse/DF-832
About these changes
Integrating the GDS accordion component into search filters
How to check these changes
Performa search, open and close the filter accordion, apply filters to confirm functionality. Test across viewports.
Before assigning to reviewer, please make sure you have
Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md